[Thunar-dev] Patch for "Open Terminal Here" keyboard shortcut

[Jogy Antony]

Hello

I am new to the open source world. I have made a patch to add a
shortcut key to "Open Terminal Here" to be integrated with Thunar.
This is a popular request. See

http://forum.xfce.org/viewtopic.php?id=3885
http://forum.xfce.org/viewtopic.php?id=4703
http://www.linuxformat.com/forums/viewtopic.php?p=74240

It is a little bit of a hack. Would it be possible for me
to get it integrated to Thunar?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: open_xfce4_term_here.patch
Type: text/x-patch
Size: 4157 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/thunar-dev/attachments/20111106/5e3bf48c/attachment.bin>

[Robert Orzanna]

I am not a programmer so I cannot help you revising your code.

However, I really like the implementation and hope it to be included in thunar!

Thank you,

Robert

Post by Jogy Antony
Hello
I am new to the open source world. I have made a patch to add a
shortcut key to "Open Terminal Here" to be integrated with Thunar.
This is a popular request. See
http://forum.xfce.org/viewtopic.php?id=3885
http://forum.xfce.org/viewtopic.php?id=4703
http://www.linuxformat.com/forums/viewtopic.php?p=74240
It is a little bit of a hack. Would it be possible for me
to get it integrated to Thunar?
_______________________________________________
Thunar-dev mailing list
Thunar-dev at xfce.org
https://mail.xfce.org/mailman/listinfo/thunar-dev

[Jogy Antony]

Thanks for all the feedback.
That makes it pretty straight forward.

But I tried this patch , but here i got a problem ,
When terminal is opened with "F4" , have you tried to close that
Thunar Window ? It's unable to be closed.
And multiple terminal (Press F4 for more than one time won't work ..)

I screwed up. The wait() should not have been there.
Your implementation is much better. It works on my Debian Wheezy.

I haven't tried it, but the first thing that caught my eye was that the
patch doesn't take into account the user's perference for the terminal
application. Maybe consider using 'exo-open --launch TerminalEmulator
--working-directory <dir>' instead?
--
`Experience is the best teacher.'
_______________________________________________
Xfce4-dev mailing list
Xfce4-dev at xfce.org
https://mail.xfce.org/mailman/listinfo/xfce4-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: open_xfce4_term_here.patch
Type: text/x-patch
Size: 3763 bytes
Desc: not available
URL: <http://mail.xfce.org/pipermail/thunar-dev/attachments/20111106/457db6a9/attachment.bin>